christoph/fail
1
Fork 0
Code Releases Activity

import-trace: initialize all members

Browse Source 
This was never a real problem, but keeps us on the safe side.  Found
by Coverity Scan, CID 25731/25808/25817.

Change-Id: Ie4bd9fb52ff6140ce7ae024738b43c82f6f5045c
This commit is contained in:
Horst Schirmeier
2015-02-07 15:58:23 +01:00
parent 41a191eeaa
commit b01a5e80fd
3 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tools/import-trace/AdvancedMemoryImporter.hpp
View File

@ -44,7 +44,8 @@ class AdvancedMemoryImporter : public MemoryImporter {
void insert_delayed_entries(bool finalizing);
public:
AdvancedMemoryImporter() : m_last_was_conditional_branch(false) {}
AdvancedMemoryImporter() : m_last_was_conditional_branch(false),
m_ip_jump_not_taken(0), m_cur_branchmask(0) {}
protected:
virtual std::string database_additional_columns();

5
tools/import-trace/Importer.hpp
View File

@ -119,7 +119,10 @@ protected:
*/
bool sanitycheck(std::string check_name, std::string fail_msg, std::string sql);
public:
Importer() : m_sanitychecks(false), m_import_write_ecs(true), m_extended_trace(false), m_row_count(0), m_time_trace_start(0) {}
Importer() : m_variant_id(0), m_elf(NULL), m_mm(NULL), m_faultspace_rightmargin('W'),
m_sanitychecks(false), m_import_write_ecs(true), m_extended_trace(false), db(NULL),
m_extended_trace_regs(NULL), m_row_count(0), m_time_trace_start(0),
m_last_ip(0), m_last_instr(0), m_last_time(0) {}
bool init(const std::string &variant, const std::string &benchmark, fail::Database *db);
/**

2
tools/import-trace/RegisterImporter.hpp
View File

@ -25,7 +25,7 @@ class RegisterImporter : public Importer {
public:
RegisterImporter() : Importer(), do_gp(true), do_flags(false), do_ip(false),
do_split_registers(true) {}
do_split_registers(true), m_ip_register_id(0) {}
/**
* Callback function that can be used to add command line options
* to the cmd interface