From b01a5e80fd625b34f17905d3bc1a99bda535307d Mon Sep 17 00:00:00 2001 From: Horst Schirmeier Date: Sat, 7 Feb 2015 15:58:23 +0100 Subject: [PATCH] import-trace: initialize all members This was never a real problem, but keeps us on the safe side. Found by Coverity Scan, CID 25731/25808/25817. Change-Id: Ie4bd9fb52ff6140ce7ae024738b43c82f6f5045c --- tools/import-trace/AdvancedMemoryImporter.hpp | 3 ++- tools/import-trace/Importer.hpp | 5 ++++- tools/import-trace/RegisterImporter.hpp | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/tools/import-trace/AdvancedMemoryImporter.hpp b/tools/import-trace/AdvancedMemoryImporter.hpp index 504efcf1..9584de5f 100644 --- a/tools/import-trace/AdvancedMemoryImporter.hpp +++ b/tools/import-trace/AdvancedMemoryImporter.hpp @@ -44,7 +44,8 @@ class AdvancedMemoryImporter : public MemoryImporter { void insert_delayed_entries(bool finalizing); public: - AdvancedMemoryImporter() : m_last_was_conditional_branch(false) {} + AdvancedMemoryImporter() : m_last_was_conditional_branch(false), + m_ip_jump_not_taken(0), m_cur_branchmask(0) {} protected: virtual std::string database_additional_columns(); diff --git a/tools/import-trace/Importer.hpp b/tools/import-trace/Importer.hpp index 1f76476d..3b210ca9 100644 --- a/tools/import-trace/Importer.hpp +++ b/tools/import-trace/Importer.hpp @@ -119,7 +119,10 @@ protected: */ bool sanitycheck(std::string check_name, std::string fail_msg, std::string sql); public: - Importer() : m_sanitychecks(false), m_import_write_ecs(true), m_extended_trace(false), m_row_count(0), m_time_trace_start(0) {} + Importer() : m_variant_id(0), m_elf(NULL), m_mm(NULL), m_faultspace_rightmargin('W'), + m_sanitychecks(false), m_import_write_ecs(true), m_extended_trace(false), db(NULL), + m_extended_trace_regs(NULL), m_row_count(0), m_time_trace_start(0), + m_last_ip(0), m_last_instr(0), m_last_time(0) {} bool init(const std::string &variant, const std::string &benchmark, fail::Database *db); /** diff --git a/tools/import-trace/RegisterImporter.hpp b/tools/import-trace/RegisterImporter.hpp index 42c45cce..87fc1f14 100644 --- a/tools/import-trace/RegisterImporter.hpp +++ b/tools/import-trace/RegisterImporter.hpp @@ -25,7 +25,7 @@ class RegisterImporter : public Importer { public: RegisterImporter() : Importer(), do_gp(true), do_flags(false), do_ip(false), - do_split_registers(true) {} + do_split_registers(true), m_ip_register_id(0) {} /** * Callback function that can be used to add command line options * to the cmd interface