christoph/fail
1
Fork 0
Code Releases Activity

[generic-experiment] make text segment listener, listen only to writes

Browse Source 
The generic experiment set the TriggerAccessType not the
WatchAccessType. Therefore, the text segment listener fired on write
AND read events. The watch access type can only be set in the constructor.
This commit is contained in:
Malte Bargholz
2020-10-14 15:05:36 +02:00
committed by Christian Dietrich
parent cd150a6f5b
commit eb43273e9b
2 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/experiments/generic-experiment/experiment.cc
View File

@ -220,7 +220,6 @@ bool GenericExperiment::cb_start_experiment() {
l_mem_text.setWatchAddress(bounds.first);
l_mem_text.setWatchWidth(bounds.second - bounds.first);
l_mem_text.setTriggerAccessType(MemAccessEvent::MEM_WRITE);
}
@ -232,7 +231,6 @@ bool GenericExperiment::cb_start_experiment() {
l_mem_outerspace.setWatchAddress(bounds.second);
l_mem_outerspace.setWatchWidth(numeric_limits<guest_address_t>::max() - bounds.second);
l_mem_outerspace.setTriggerAccessType(MemAccessEvent::MEM_WRITE);
}
if (cmd[WRITE_MEM_LOWERSPACE]) {
@ -245,7 +243,6 @@ bool GenericExperiment::cb_start_experiment() {
// however, this is not the case for RISC-V and consequently, it is ignored here.
l_mem_lowerspace.setWatchAddress(numeric_limits<guest_address_t>::min());
l_mem_lowerspace.setWatchWidth(bounds.first - numeric_limits<guest_address_t>::min());
l_mem_lowerspace.setTriggerAccessType(MemAccessEvent::MEM_WRITE);
}
if (cmd[TRAP]) {

2
src/experiments/generic-experiment/experiment.hpp
View File

@ -26,7 +26,7 @@ class GenericExperiment : public fail::DatabaseExperiment {
std::string serial_goldenrun;
bool enabled_mem_text;
fail::MemAccessListener l_mem_text;
fail::MemWriteListener l_mem_text;
bool enabled_mem_outerspace;
fail::MemAccessListener l_mem_outerspace;