christoph/fail
1
Fork 0
Code Actions Packages Releases Activity

FIXMEs and comments updated due to last architecture-related changes

Browse Source 
git-svn-id: https://www4.informatik.uni-erlangen.de/i4svn/danceos/trunk/devel/fail@2005 8c4709b5-6ec9-48aa-a5cd-a96041d1645a
This commit is contained in:
adrian
2013-01-17 13:41:03 +00:00
parent c4e5ab4f58
commit d3cf2359a4
4 changed files with 12 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/core/sal/CPUState.cc
View File

@ -2,7 +2,6 @@
namespace fail {
// FIXME: Bochs specific? If not, at least get rid of this global variable.
int interrupt_to_fire = -1;
bool CPUState::isSuppressedInterrupt(unsigned interruptNum)
@ -11,12 +10,14 @@ bool CPUState::isSuppressedInterrupt(unsigned interruptNum)
if ((m_SuppressedInterrupts[i] == interruptNum ||
m_SuppressedInterrupts[i] == ANY_INTERRUPT) &&
interruptNum != (unsigned)interrupt_to_fire + 32) {
// FIXME: This should be dead code...(?)
if ((int)interruptNum == interrupt_to_fire + 32) {
interrupt_to_fire = -1;
return true;
}
return true;
}
// FIXME: This is simulator-(x86)-specific stuff... (?)
return false;
}
@ -25,7 +26,9 @@ bool CPUState::addSuppressedInterrupt(unsigned interruptNum)
// Check if already existing:
if (isSuppressedInterrupt(interruptNum+32))
return false; // already added: nothing to do here
// FIXME: addSuppressedInterrupt(ANY_INTERRUPT) can still be called more
// than once. This is not handled by the if-statement above.
if (interruptNum == ANY_INTERRUPT)
m_SuppressedInterrupts.push_back(interruptNum);
else