christoph/fail
1
Fork 0
Code Actions Packages Releases Activity

Revert "import-trace: emit warning for malformed traces"

Browse Source 
Memory accesses that don't belong to the preceding IP event in the
trace *do* have a use case:  a hardware interrupt causes the CPU to
push its state onto the (kernel) stack.  At the moment we cannot
distinguish this case from a malformed trace (as we don't record the
occurrence of interrupts), hence this warning needs to be disabled for
now.

This reverts commit 84edd02b6f.
This commit is contained in:
Horst Schirmeier
2014-02-11 14:57:29 +01:00
parent 8942740d9a
commit b4f144745a
1 changed files with 0 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tools/import-trace/Importer.cc
View File

@ -68,8 +68,6 @@ bool Importer::copy_to_database(fail::ProtoIStream &ps) {
instruction_count_t instr = 0; instruction_count_t instr = 0;
// instruction counter new memory access events belong to // instruction counter new memory access events belong to
instruction_count_t instr_memaccess = 0; instruction_count_t instr_memaccess = 0;
// absolute instruction address of the latest IP event
guest_address_t instr_memaccess_absolute = 0;
// the currently processed event // the currently processed event
Trace_Event ev; Trace_Event ev;
@ -106,15 +104,8 @@ bool Importer::copy_to_database(fail::ProtoIStream &ps) {
// all subsequent mem access events belong to this dynamic instr // all subsequent mem access events belong to this dynamic instr
instr_memaccess = instr; instr_memaccess = instr;
instr_memaccess_absolute = ev.ip();
instr++; instr++;
} else { } else {
if (ev.ip() != instr_memaccess_absolute) {
LOG << "warning: mem-access IP 0x" << std::hex << ev.ip()
<< " differs from previous instruction IP 0x" << instr_memaccess_absolute
<< " at instr=" << std::dec << instr_memaccess
<< " (mem accesses must follow *after* their corresponding IP events in the trace!)" << std::endl;
}
if (!handle_mem_event(curtime, instr_memaccess, ev)) { if (!handle_mem_event(curtime, instr_memaccess, ev)) {
LOG << "error: handle_mem_event() failed at instr=" << instr_memaccess << std::endl; LOG << "error: handle_mem_event() failed at instr=" << instr_memaccess << std::endl;
return false; return false;