From b4f144745a6688be3d16aac75167257384cf755c Mon Sep 17 00:00:00 2001 From: Horst Schirmeier Date: Tue, 11 Feb 2014 14:57:29 +0100 Subject: [PATCH] Revert "import-trace: emit warning for malformed traces" Memory accesses that don't belong to the preceding IP event in the trace *do* have a use case: a hardware interrupt causes the CPU to push its state onto the (kernel) stack. At the moment we cannot distinguish this case from a malformed trace (as we don't record the occurrence of interrupts), hence this warning needs to be disabled for now. This reverts commit 84edd02b6fd129bc240b06106fd02ac3ea4b8b20. --- tools/import-trace/Importer.cc | 9 --------- 1 file changed, 9 deletions(-) diff --git a/tools/import-trace/Importer.cc b/tools/import-trace/Importer.cc index 019dc5d9..927145f7 100644 --- a/tools/import-trace/Importer.cc +++ b/tools/import-trace/Importer.cc @@ -68,8 +68,6 @@ bool Importer::copy_to_database(fail::ProtoIStream &ps) { instruction_count_t instr = 0; // instruction counter new memory access events belong to instruction_count_t instr_memaccess = 0; - // absolute instruction address of the latest IP event - guest_address_t instr_memaccess_absolute = 0; // the currently processed event Trace_Event ev; @@ -106,15 +104,8 @@ bool Importer::copy_to_database(fail::ProtoIStream &ps) { // all subsequent mem access events belong to this dynamic instr instr_memaccess = instr; - instr_memaccess_absolute = ev.ip(); instr++; } else { - if (ev.ip() != instr_memaccess_absolute) { - LOG << "warning: mem-access IP 0x" << std::hex << ev.ip() - << " differs from previous instruction IP 0x" << instr_memaccess_absolute - << " at instr=" << std::dec << instr_memaccess - << " (mem accesses must follow *after* their corresponding IP events in the trace!)" << std::endl; - } if (!handle_mem_event(curtime, instr_memaccess, ev)) { LOG << "error: handle_mem_event() failed at instr=" << instr_memaccess << std::endl; return false;