christoph/fail
1
Fork 0
Code Releases Activity

util/llvmdisassembler: fix address -> register translation

Browse Source 
Due to a typo (cast to regwidth_t instead of regdata_t), accesses to
register content beyond an offset of 32 bits via
LLVMtoFailTranslator::reginfo_t did not work correctly.  Additionally, this
change fixes constructing reginfo_t with a bit width >= 64 (e.g. the whole
RAX register).

Change-Id: I24914cd64fa51118eeac38cc3fb47b76790d3aac
This commit is contained in:
Horst Schirmeier
2018-12-11 14:09:27 +01:00
parent 50704e9b59
commit 924e234db1
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/core/util/llvmdisassembler/LLVMtoFailTranslator.hpp
View File

@ -38,7 +38,15 @@ public:
}
reginfo_t(int id=-1, regwidth_t width = 32, byte_t offs = 0)
: id(id), width(width), mask((regwidth_t)((((long long)1 << width) - 1) << offs)), offset(offs) {};
: id(id), width(width), mask((((regdata_t) 1 << width) - 1) << offs), offset(offs)
{
if (width >= sizeof(regdata_t) * 8) { // all ones, (1 << width) == 0!
mask = -1;
}
#if 0
std::cerr << "constructing reginfo_t: " << std::dec << id << " " << width << " " << ((int)offs) << std::hex << " 0x" << mask << std::endl;
#endif
}
};
protected: