christoph/wamr
1
Fork 0
Code Releases Activity

fd_object_release: Preserve errno (#2535)

Browse Source 
Preserve errno because this function is often used like
the following. The caller wants to report the error from the main
operation (`lseek` in this example), not from fd_object_release.

```
    off_t ret = lseek(fd_number(fo), offset, nwhence);
    fd_object_release(fo);
    if (ret < 0)
        return convert_errno(errno);
```
This commit is contained in:
YAMAMOTO Takashi
2023-09-08 13:26:32 +09:00
committed by GitHub
parent 534a8cf9f4
commit f128150d43
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/posix.c
View File

@ -642,6 +642,7 @@ static void
fd_object_release(struct fd_object *fo) UNLOCKS(fo->refcount) fd_object_release(struct fd_object *fo) UNLOCKS(fo->refcount)
{ {
if (refcount_release(&fo->refcount)) { if (refcount_release(&fo->refcount)) {
int saved_errno = errno;
switch (fo->type) { switch (fo->type) {
case __WASI_FILETYPE_DIRECTORY: case __WASI_FILETYPE_DIRECTORY:
// For directories we may keep track of a DIR object. Calling // For directories we may keep track of a DIR object. Calling
@ -659,6 +660,7 @@ fd_object_release(struct fd_object *fo) UNLOCKS(fo->refcount)
break; break;
} }
wasm_runtime_free(fo); wasm_runtime_free(fo);
errno = saved_errno;
} }
} }