christoph/wamr
1
Fork 0
Code Releases Activity

Add wamrc parameter to configure stack frame features (#3763)

Browse Source 
Those parameters can be used to reduce the size of the AOT code.

There's going to be more changes related to AOT code size reduction,
this is just the initial step.

p.s. https://github.com/bytecodealliance/wasm-micro-runtime/issues/3758
This commit is contained in:
Marcin Kolny
2024-09-05 14:44:06 +01:00
committed by GitHub
parent b4380fb3b1
commit 6f97822c18
9 changed files with 127 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

70
wamr-compiler/main.c
View File

@ -162,6 +162,12 @@ print_help()
printf(" GC is enabled\n");
printf(" --disable-aux-stack-check Disable auxiliary stack overflow/underflow check\n");
printf(" --enable-dump-call-stack Enable stack trace feature\n");
printf(" --call-stack-features=<features>\n");
printf(" A comma-separated list of features when generating call stacks.\n");
printf(" By default, all features are enabled. To disable all features,\n");
printf(" provide an empty list (i.e. --call-stack-features=). This flag\n");
printf(" only only takes effect when --enable-dump-call-stack is set.\n");
printf(" Available features: bounds-checks, ip, trap-ip, values.\n");
printf(" --enable-perf-profiling Enable function performance profiling\n");
printf(" --enable-memory-profiling Enable memory usage profiling\n");
printf(" --xip A shorthand of --enable-indirect-mode --disable-llvm-intrinsics\n");
@ -259,6 +265,48 @@ split_string(char *str, int *count, const char *delimer)
return res;
}
static bool
parse_call_stack_features(char *features_str,
AOTCallStackFeatures *out_features)
{
int size = 0;
char **features;
bool ret = true;
bh_assert(features_str);
bh_assert(out_features);
/* non-empty feature list */
features = split_string(features_str, &size, ",");
if (!features) {
return false;
}
while (size--) {
if (!strcmp(features[size], "bounds-checks")) {
out_features->bounds_checks = true;
}
else if (!strcmp(features[size], "ip")) {
out_features->ip = true;
}
else if (!strcmp(features[size], "trap-ip")) {
out_features->trap_ip = true;
}
else if (!strcmp(features[size], "values")) {
out_features->values = true;
}
else {
ret = false;
printf("Unsupported feature %s\n", features[size]);
goto finish;
}
}
finish:
free(features);
return ret;
}
static uint32
resolve_segue_flags(char *str_flags)
{
@ -356,6 +404,9 @@ main(int argc, char *argv[])
option.enable_ref_types = true;
option.enable_gc = false;
/* Set all the features to true by default */
memset(&option.call_stack_features, 1, sizeof(AOTCallStackFeatures));
/* Process options */
for (argc--, argv++; argc > 0 && argv[0][0] == '-'; argc--, argv++) {
if (!strcmp(argv[0], "-o")) {
@ -470,6 +521,19 @@ main(int argc, char *argv[])
else if (!strcmp(argv[0], "--enable-dump-call-stack")) {
option.enable_aux_stack_frame = true;
}
else if (!strncmp(argv[0], "--call-stack-features=", 22)) {
/* Reset all the features, only enable the user-defined ones */
memset(&option.call_stack_features, 0,
sizeof(AOTCallStackFeatures));
if (argv[0][22] != '\0') {
if (!parse_call_stack_features(argv[0] + 22,
&option.call_stack_features)) {
printf("Failed to parse call-stack-features\n");
PRINT_HELP_AND_EXIT();
}
}
}
else if (!strcmp(argv[0], "--enable-perf-profiling")) {
option.enable_aux_stack_frame = true;
option.enable_perf_profiling = true;
@ -608,6 +672,12 @@ main(int argc, char *argv[])
#endif
}
if (option.enable_gc && !option.call_stack_features.values) {
LOG_WARNING("Call stack feature 'values' must be enabled for GC. The "
"feature will be enabled automatically.");
option.call_stack_features.values = true;
}
if (sgx_mode) {
option.size_level = 1;
option.is_sgx_platform = true;