From 6e547baf46dc4f44b68818fc27adf969134febe6 Mon Sep 17 00:00:00 2001 From: YAMAMOTO Takashi Date: Tue, 6 Feb 2024 14:14:25 +0900 Subject: [PATCH] aot_compile_op_call: Stop setting calling convention explicitly (#3140) The current logic doesn't work for some cases. cf. https://github.com/bytecodealliance/wasm-micro-runtime/issues/3138 It's unclear why we are setting the calling convention explicitly here at all. In many cases, the default just seems working. --- core/iwasm/compilation/aot_emit_function.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/core/iwasm/compilation/aot_emit_function.c b/core/iwasm/compilation/aot_emit_function.c index 4fb07240..ef85941a 100644 --- a/core/iwasm/compilation/aot_emit_function.c +++ b/core/iwasm/compilation/aot_emit_function.c @@ -1088,10 +1088,6 @@ aot_compile_op_call(AOTCompContext *comp_ctx, AOTFuncContext *func_ctx, goto fail; } - /* Set calling convention for the call with the func's calling - convention */ - LLVMSetInstructionCallConv(value_ret, LLVMGetFunctionCallConv(func)); - if (tail_call) LLVMSetTailCall(value_ret, true);