christoph/wamr
1
Fork 0
Code Releases Activity

Use cmake POSITION_INDEPENDENT_CODE instead of hardcoding -pie -fPIE (#1598)

Browse Source 
This fixes unused option warnings on -pie for macOS.
(On macOS cmake produces "-fPIE -Xlinker -pie")

Bump required cmake version to 3.14 for CheckPIESupported.

References:
https://cmake.org/cmake/help/latest/prop_tgt/POSITION_INDEPENDENT_CODE.html
https://cmake.org/cmake/help/latest/module/CheckPIESupported.html#module:CheckPIESupported
This commit is contained in:
YAMAMOTO Takashi
2022-10-19 02:51:18 +09:00
committed by GitHub
parent e87a554616
commit 654ac5feca
12 changed files with 68 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
samples/multi-module/CMakeLists.txt
View File

@ -1,7 +1,10 @@
# Copyright (C) 2019 Intel Corporation. All rights reserved.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
cmake_minimum_required (VERSION 2.8...3.16)
cmake_minimum_required (VERSION 3.14)
include(CheckPIESupported)
project(multi_module)
################ runtime settings ################
@ -47,7 +50,6 @@ set(WAMR_BUILD_LIBC_WASI 1)
set(WAMR_BUILD_MULTI_MODULE 1)
# compiling and linking flags
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -pie -fPIE")
if (NOT (CMAKE_C_COMPILER MATCHES ".*clang.*" OR CMAKE_C_COMPILER_ID MATCHES ".*Clang"))
set (CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,--gc-sections")
endif ()
@ -150,5 +152,8 @@ add_executable(multi_module src/main.c ${UNCOMMON_SHARED_SOURCE})
add_dependencies(multi_module vmlib WASM_MODULE)
check_pie_supported()
set_target_properties (multi_module PROPERTIES POSITION_INDEPENDENT_CODE ON)
# libraries
target_link_libraries(multi_module PRIVATE vmlib -lpthread -lm)