christoph/wamr
1
Fork 0
Code Releases Activity

Fix return value not checked issue reported by Coverity (#1156)

Browse Source 
Fix return value not checked issue in function init_wasm_timer,
reported by Coverity
This commit is contained in:
Xu Jun
2022-05-07 19:22:00 +08:00
committed by GitHub
parent ed512c6867
commit 474f081f56
7 changed files with 52 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/app-framework/base/native/runtime_lib.h
View File

@ -8,7 +8,7 @@
#include "runtime_timer.h"
void
bool
init_wasm_timer();
void
exit_wasm_timer();

27
core/app-framework/base/native/timer_wrapper.c
View File

@ -83,19 +83,36 @@ wakeup_modules_timer_thread(timer_ctx_t ctx)
os_mutex_unlock(&g_timer_ctx_list_mutex);
}
void
bool
init_wasm_timer()
{
korp_tid tm_tid;
bh_list_init(&g_timer_ctx_list);
os_cond_init(&g_timer_ctx_list_cond);
if (os_cond_init(&g_timer_ctx_list_cond) != 0) {
return false;
}
/* temp solution for: thread_modulers_timer_check thread
would recursive lock the mutex */
os_recursive_mutex_init(&g_timer_ctx_list_mutex);
if (os_recursive_mutex_init(&g_timer_ctx_list_mutex) != 0) {
goto fail1;
}
os_thread_create(&tm_tid, thread_modulers_timer_check, NULL,
BH_APPLET_PRESERVED_STACK_SIZE);
if (0
!= os_thread_create(&tm_tid, thread_modulers_timer_check, NULL,
BH_APPLET_PRESERVED_STACK_SIZE)) {
goto fail2;
}
return true;
fail2:
os_mutex_destroy(&g_timer_ctx_list_mutex);
fail1:
os_cond_destroy(&g_timer_ctx_list_cond);
return false;
}
void