christoph/wamr
1
Fork 0
Code Releases Activity

Make robust on choosing target assumption for X86_32 support (#1241)

Browse Source 
When WAMR_BUILD_TARGET isn't set, choosing right target is decided
by checking `CMAKE_SIZEOF_VOID_P` variable. However, choosing `X86_32`
target is not doing specifically checking size of void pointer. It is kind
a fallback target for others.

This patch explicitly checks the size of void pointer before setting the target
to `X86_32` to fix the issue.
This commit is contained in:
Cengizhan Pasaoglu
2022-06-27 14:30:31 +02:00
committed by GitHub
parent eb3cdaaf32
commit 2746d29751
17 changed files with 51 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
samples/wasm-c-api/CMakeLists.txt
View File

@ -39,9 +39,11 @@ if (NOT DEFINED WAMR_BUILD_TARGET)
elseif (CMAKE_SIZEOF_VOID_P EQUAL 8)
# Build as X86_64 by default in 64-bit platform
set (WAMR_BUILD_TARGET "X86_64")
else ()
elseif (CMAKE_SIZEOF_VOID_P EQUAL 4)
# Build as X86_32 by default in 32-bit platform
set (WAMR_BUILD_TARGET "X86_32")
else ()
message(SEND_ERROR "Unsupported build target platform!")
endif ()
endif ()