Add mutex initializer for wasm-c-api engine operations (#1656)
The host embedder may new/delete wasm-c-api engine simultaneously in multiple threads, which requires lock for the operations. Since there isn't one time called global init/destroy APIs provided by wasm-c-api, we define a global lock and initialize it with thread mutex initializer if the platform supports that, and use it to lock the operations of engine. If the platform doesn't support thread mutex initializer, we require developer to create the lock by himself to ensure the thread-safe of the engine operations.
This commit is contained in:
@ -56,6 +56,17 @@ typedef void *korp_tid;
|
||||
typedef void *korp_mutex;
|
||||
typedef void *korp_sem;
|
||||
|
||||
/**
|
||||
* Create the mutex when os_mutex_lock is called, and no need to
|
||||
* CloseHandle() for the static lock's lifetime, since
|
||||
* "The system closes the handle automatically when the process
|
||||
* terminates. The mutex object is destroyed when its last
|
||||
* handle has been closed."
|
||||
* Refer to:
|
||||
* https://learn.microsoft.com/en-us/windows/win32/api/synchapi/nf-synchapi-createmutexa
|
||||
*/
|
||||
#define OS_THREAD_MUTEX_INITIALIZER NULL
|
||||
|
||||
struct os_thread_wait_node;
|
||||
typedef struct os_thread_wait_node *os_thread_wait_list;
|
||||
typedef struct korp_cond {
|
||||
|
||||
@ -512,6 +512,21 @@ os_mutex_lock(korp_mutex *mutex)
|
||||
int ret;
|
||||
|
||||
assert(mutex);
|
||||
|
||||
if (*mutex == NULL) { /* static initializer? */
|
||||
HANDLE p = CreateMutex(NULL, FALSE, NULL);
|
||||
|
||||
if (!p) {
|
||||
return BHT_ERROR;
|
||||
}
|
||||
|
||||
if (InterlockedCompareExchangePointer((PVOID *)mutex, (PVOID)p, NULL)
|
||||
!= NULL) {
|
||||
/* lock has been created by other threads */
|
||||
CloseHandle(p);
|
||||
}
|
||||
}
|
||||
|
||||
ret = WaitForSingleObject(*mutex, INFINITE);
|
||||
return ret != WAIT_FAILED ? BHT_OK : BHT_ERROR;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user