christoph/lecture-professional-software-development
1
Fork 0
Code Activity

refactor WebController

Browse Source
This commit is contained in:
killerber4t
2020-03-24 15:57:31 +01:00
parent 80ab65febb
commit f907c617a8
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/main/java/mops/gruppen2/controller/WebController.java
View File

@ -165,7 +165,7 @@ public class WebController {
if (search != null) { if (search != null) {
groupse = groupService.findGroupWith(search, account); groupse = groupService.findGroupWith(search, account);
} }
model.addAttribute("account", keyCloakService.createAccountFromPrincipal(token)); model.addAttribute("account", account);
model.addAttribute("gruppen", groupse); model.addAttribute("gruppen", groupse);
return "search"; return "search";
} }
@ -176,6 +176,7 @@ public class WebController {
Model model, Model model,
@PathVariable("id") String groupId) throws EventException { @PathVariable("id") String groupId) throws EventException {
model.addAttribute("account", keyCloakService.createAccountFromPrincipal(token)); model.addAttribute("account", keyCloakService.createAccountFromPrincipal(token));
Group group = userService.getGroupById(UUID.fromString(groupId)); Group group = userService.getGroupById(UUID.fromString(groupId));
Account account = keyCloakService.createAccountFromPrincipal(token); Account account = keyCloakService.createAccountFromPrincipal(token);
User user = new User(account.getName(), account.getGivenname(), account.getFamilyname(), account.getEmail()); User user = new User(account.getName(), account.getGivenname(), account.getFamilyname(), account.getEmail());
@ -215,12 +216,11 @@ public class WebController {
public String joinGroup(KeycloakAuthenticationToken token, public String joinGroup(KeycloakAuthenticationToken token,
Model model, @RequestParam("id") String groupId) throws EventException { Model model, @RequestParam("id") String groupId) throws EventException {
model.addAttribute("account", keyCloakService.createAccountFromPrincipal(token)); model.addAttribute("account", keyCloakService.createAccountFromPrincipal(token));
Account account = keyCloakService.createAccountFromPrincipal(token); Account account = keyCloakService.createAccountFromPrincipal(token);
User user = new User(account.getName(), account.getGivenname(), account.getFamilyname(), account.getEmail()); User user = new User(account.getName(), account.getGivenname(), account.getFamilyname(), account.getEmail());
Group group = userService.getGroupById(UUID.fromString(groupId)); Group group = userService.getGroupById(UUID.fromString(groupId));
if (group.getMembers().contains(user)) { if (group.getMembers().contains(user)) {
return "error"; //TODO: hier soll eigentlich auf die bereits beigetretene Gruppe weitergeleitet werden return "redirect:/gruppen2/details/" + groupId; //TODO: hier soll eigentlich auf die bereits beigetretene Gruppe weitergeleitet werden
} }
if (group.getUserMaximum() < group.getMembers().size()) { if (group.getUserMaximum() < group.getMembers().size()) {
return "error"; return "error";
@ -238,11 +238,9 @@ public class WebController {
Group group = userService.getGroupById(UUID.fromString(groupId)); Group group = userService.getGroupById(UUID.fromString(groupId));
UUID parentId = group.getParent(); UUID parentId = group.getParent();
Group parent = new Group(); Group parent = new Group();
if (parentId != null) { if (parentId != null) {
parent = userService.getGroupById(parentId); parent = userService.getGroupById(parentId);
} }
if (group.getUserMaximum() > group.getMembers().size()) { if (group.getUserMaximum() > group.getMembers().size()) {
model.addAttribute("group", group); model.addAttribute("group", group);
model.addAttribute("parentId", parentId); model.addAttribute("parentId", parentId);
@ -324,8 +322,6 @@ public class WebController {
public String changeRole(KeycloakAuthenticationToken token, public String changeRole(KeycloakAuthenticationToken token,
@RequestParam("group_id") String groupId, @RequestParam("group_id") String groupId,
@RequestParam("user_id") String userId) throws EventException { @RequestParam("user_id") String userId) throws EventException {
Account account = keyCloakService.createAccountFromPrincipal(token); Account account = keyCloakService.createAccountFromPrincipal(token);
if (userId.equals(account.getName())) { if (userId.equals(account.getName())) {
if (controllerService.passIfLastAdmin(account, UUID.fromString(groupId))) { if (controllerService.passIfLastAdmin(account, UUID.fromString(groupId))) {