christoph/lecture-professional-software-development
1
Fork 0
Code Activity

fix tests after refactor

Browse Source
This commit is contained in:
Christoph
2020-03-09 12:46:29 +01:00
parent c7f9c0b985
commit 86a4975c00
4 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/mops/gruppen2/domain/Aggregate.java
View File

@ -8,9 +8,9 @@ import java.lang.reflect.Method;
/** /**
* Repräsentiert viele Events als aggregiertes Objekt. * Repräsentiert viele Events als aggregiertes Objekt.
*/ */
@Getter
public abstract class Aggregate { public abstract class Aggregate {
@Getter
protected long id; protected long id;
/** /**

1
src/main/java/mops/gruppen2/domain/Group.java
View File

@ -25,6 +25,7 @@ public class Group extends Aggregate {
private void applyEvent(CreateGroupEvent event) { private void applyEvent(CreateGroupEvent event) {
title = event.getGroupTitle(); title = event.getGroupTitle();
description = event.getGroupDescription(); description = event.getGroupDescription();
id = event.getGroup_id();
} }
private void applyEvent(UpdateRoleEvent event) { private void applyEvent(UpdateRoleEvent event) {

6
src/main/java/mops/gruppen2/service/GroupService.java
View File

@ -1,9 +1,9 @@
package mops.gruppen2.service; package mops.gruppen2.service;
import mops.gruppen2.domain.Group; import mops.gruppen2.domain.Group;
import mops.gruppen2.domain.event.CreateGroupEvent;
import mops.gruppen2.domain.event.Event; import mops.gruppen2.domain.event.Event;
import org.springframework.stereotype.Service; import org.springframework.stereotype.Service;
import java.util.List; import java.util.List;
@Service @Service
@ -16,8 +16,8 @@ public class GroupService {
* @param eventList Die restlichen Events für diese Gruppe * @param eventList Die restlichen Events für diese Gruppe
* @return Gruppe auf aktuellem Stand * @return Gruppe auf aktuellem Stand
*/ */
Group buildGroupFromEvents(CreateGroupEvent event, List<Event> eventList) { Group buildGroupFromEvents(List<Event> eventList) {
Group newGroup = new Group(event); Group newGroup = new Group();
eventList.forEach(newGroup::applyEvent); eventList.forEach(newGroup::applyEvent);

15
src/test/java/mops/gruppen2/domain/GroupTest.java
View File

@ -23,9 +23,10 @@ class GroupTest {
@Test @Test
void createSingleGroup() { void createSingleGroup() {
CreateGroupEvent createGroupEvent = new CreateGroupEvent(1L,2, "asd", "hello", "foo"); CreateGroupEvent createGroupEvent = new CreateGroupEvent(1,2, "asd", "hello", "foo");
Group group = new Group(createGroupEvent); Group group = new Group();
group.applyEvent(createGroupEvent);
assertThat(group.getDescription()).isEqualTo("foo"); assertThat(group.getDescription()).isEqualTo("foo");
assertThat(group.getTitle()).isEqualTo("hello"); assertThat(group.getTitle()).isEqualTo("hello");
@ -35,11 +36,12 @@ class GroupTest {
// Verwendet CreateGroupEvent // Verwendet CreateGroupEvent
@Test @Test
void addSingleUser() { void addSingleUser() {
CreateGroupEvent createGroupEvent = new CreateGroupEvent(1L,1L,"prof1", "hi", "foo"); CreateGroupEvent createGroupEvent = new CreateGroupEvent(1,1,"prof1", "hi", "foo");
Group group = new Group(createGroupEvent); Group group = new Group();
group.applyEvent(createGroupEvent);
User user = new User("prof", "jens", "bendi", "hi@gmail.com"); User user = new User("prof", "jens", "bendi", "hi@gmail.com");
AddUserEvent addUserEvent = new AddUserEvent(1L,1L, user); AddUserEvent addUserEvent = new AddUserEvent(1,1, user);
group.applyEvent(addUserEvent); group.applyEvent(addUserEvent);
assertThat(group.getMembers().get(0)).isEqualTo(user); assertThat(group.getMembers().get(0)).isEqualTo(user);
@ -52,7 +54,8 @@ class GroupTest {
CreateGroupEvent createGroupEvent = new CreateGroupEvent(1L, 1L, "1L", "gruppe1", "Eine Testgruppe"); CreateGroupEvent createGroupEvent = new CreateGroupEvent(1L, 1L, "1L", "gruppe1", "Eine Testgruppe");
AddUserEvent addUserEvent = new AddUserEvent(1L, 1L, "5L", "Peter", "Pan", "123@mail.de"); AddUserEvent addUserEvent = new AddUserEvent(1L, 1L, "5L", "Peter", "Pan", "123@mail.de");
Group group = new Group(createGroupEvent); Group group = new Group();
group.applyEvent(createGroupEvent);
group.applyEvent(addUserEvent); group.applyEvent(addUserEvent);
UpdateRoleEvent updateRoleEvent = new UpdateRoleEvent(1L, 1L, "5L", Role.ORGA); UpdateRoleEvent updateRoleEvent = new UpdateRoleEvent(1L, 1L, "5L", Role.ORGA);