new individual event-tests + removed old comments + removed doubled exception

Co-authored-by: Christoph <tobi@urpost.de>

src/main/java/mops/gruppen2/domain/event/AddUserEvent.java

@@ -1,6 +1,5 @@
 package mops.gruppen2.domain.event;
 
-import lombok.AllArgsConstructor;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 import mops.gruppen2.domain.Group;
@@ -16,7 +15,6 @@ import java.util.UUID;
  * Fügt einen einzelnen Nutzer einer Gruppe hinzu.
  */
 @Getter
-@AllArgsConstructor
 @NoArgsConstructor // For Jackson
 public class AddUserEvent extends Event {
 
@@ -33,14 +31,14 @@ public class AddUserEvent extends Event {
 
     @Override
     protected void applyEvent(Group group) throws EventException {
-        User user = new User(this.userId, this.givenname, this.familyname, this.email);
+        User user = new User(userId, givenname, familyname, email);
 
         if (group.getMembers().contains(user)) {
-            throw new UserAlreadyExistsException(this.getClass().toString());
+            throw new UserAlreadyExistsException(getClass().toString());
         }
 
         if (group.getMembers().size() >= group.getUserMaximum()) {
-            throw new GroupFullException(this.getClass().toString());
+            throw new GroupFullException(getClass().toString());
         }
 
         group.getMembers().add(user);

src/main/java/mops/gruppen2/domain/event/CreateGroupEvent.java

@@ -1,6 +1,5 @@
 package mops.gruppen2.domain.event;
 
-import lombok.AllArgsConstructor;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 import mops.gruppen2.domain.Group;
@@ -10,7 +9,6 @@ import mops.gruppen2.domain.Visibility;
 import java.util.UUID;
 
 @Getter
-@AllArgsConstructor
 @NoArgsConstructor // For Jackson
 public class CreateGroupEvent extends Event {
 
@@ -21,18 +19,18 @@ public class CreateGroupEvent extends Event {
 
     public CreateGroupEvent(UUID groupId, String userId, UUID parent, GroupType type, Visibility visibility, Long userMaximum) {
         super(groupId, userId);
-        this.groupParent = parent;
-        this.groupType = type;
-        this.groupVisibility = visibility;
-        this.groupUserMaximum = userMaximum;
+        groupParent = parent;
+        groupType = type;
+        groupVisibility = visibility;
+        groupUserMaximum = userMaximum;
     }
 
     @Override
     protected void applyEvent(Group group) {
-        group.setId(this.groupId);
-        group.setParent(this.groupParent);
-        group.setType(this.groupType);
-        group.setVisibility(this.groupVisibility);
-        group.setUserMaximum(this.groupUserMaximum);
+        group.setId(groupId);
+        group.setParent(groupParent);
+        group.setType(groupType);
+        group.setVisibility(groupVisibility);
+        group.setUserMaximum(groupUserMaximum);
     }
 }

src/main/java/mops/gruppen2/domain/event/DeleteGroupEvent.java

@@ -23,5 +23,6 @@ public class DeleteGroupEvent extends Event {
         group.setVisibility(null);
         group.setType(null);
         group.setParent(null);
+        group.setUserMaximum(0L);
     }
 }

src/main/java/mops/gruppen2/domain/event/UpdateGroupDescriptionEvent.java

@@ -1,10 +1,9 @@
 package mops.gruppen2.domain.event;
 
-import lombok.AllArgsConstructor;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 import mops.gruppen2.domain.Group;
-import mops.gruppen2.domain.exception.NoValueException;
+import mops.gruppen2.domain.exception.BadParameterException;
 
 import java.util.UUID;
 
@@ -12,7 +11,6 @@ import java.util.UUID;
  * Ändert nur die Gruppenbeschreibung.
  */
 @Getter
-@AllArgsConstructor
 @NoArgsConstructor // For Jackson
 public class UpdateGroupDescriptionEvent extends Event {
 
@@ -25,10 +23,10 @@ public class UpdateGroupDescriptionEvent extends Event {
 
     @Override
     protected void applyEvent(Group group) {
-        if (this.newGroupDescription.isEmpty()) {
-            throw new NoValueException(this.getClass().toString());
+        if (newGroupDescription.isEmpty()) {
+            throw new BadParameterException("Die Beschreibung ist leer.");
         }
 
-        group.setDescription(this.newGroupDescription);
+        group.setDescription(newGroupDescription);
     }
 }

src/main/java/mops/gruppen2/domain/event/UpdateGroupTitleEvent.java

@@ -1,10 +1,9 @@
 package mops.gruppen2.domain.event;
 
-import lombok.AllArgsConstructor;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 import mops.gruppen2.domain.Group;
-import mops.gruppen2.domain.exception.NoValueException;
+import mops.gruppen2.domain.exception.BadParameterException;
 
 import java.util.UUID;
 
@@ -12,7 +11,6 @@ import java.util.UUID;
  * Ändert nur den Gruppentitel.
  */
 @Getter
-@AllArgsConstructor
 @NoArgsConstructor // For Jackson
 public class UpdateGroupTitleEvent extends Event {
 
@@ -26,7 +24,7 @@ public class UpdateGroupTitleEvent extends Event {
     @Override
     protected void applyEvent(Group group) {
         if (newGroupTitle.isEmpty()) {
-            throw new NoValueException(getClass().toString());
+            throw new BadParameterException("Der Titel ist leer.");
         }
 
         group.setTitle(newGroupTitle);

src/main/java/mops/gruppen2/domain/event/UpdateRoleEvent.java

@@ -1,6 +1,5 @@
 package mops.gruppen2.domain.event;
 
-import lombok.AllArgsConstructor;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 import mops.gruppen2.domain.Group;
@@ -13,7 +12,6 @@ import java.util.UUID;
  * Aktualisiert die Gruppenrolle eines Teilnehmers.
  */
 @Getter
-@AllArgsConstructor
 @NoArgsConstructor // For Jackson
 public class UpdateRoleEvent extends Event {
 
@@ -26,12 +24,12 @@ public class UpdateRoleEvent extends Event {
 
     @Override
     protected void applyEvent(Group group) throws UserNotFoundException {
-        if (group.getRoles().containsKey(this.userId)) {
-            group.getRoles().put(this.userId, this.newRole);
+        if (group.getRoles().containsKey(userId)) {
+            group.getRoles().put(userId, newRole);
             return;
         }
 
-        throw new UserNotFoundException(this.getClass().toString());
+        throw new UserNotFoundException(getClass().toString());
     }
 
 }

src/main/java/mops/gruppen2/domain/event/UpdateUserMaxEvent.java

@@ -1,15 +1,14 @@
 package mops.gruppen2.domain.event;
 
-import lombok.AllArgsConstructor;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 import mops.gruppen2.domain.Group;
+import mops.gruppen2.domain.exception.BadParameterException;
 import mops.gruppen2.domain.exception.EventException;
 
 import java.util.UUID;
 
 @Getter
-@AllArgsConstructor
 @NoArgsConstructor
 public class UpdateUserMaxEvent extends Event {
 
@@ -22,6 +21,10 @@ public class UpdateUserMaxEvent extends Event {
 
     @Override
     protected void applyEvent(Group group) throws EventException {
+        if (userMaximum <= 0 || userMaximum < group.getMembers().size()) {
+            throw new BadParameterException("Usermaximum zu klein.");
+        }
+
         group.setUserMaximum(userMaximum);
     }
 }

src/main/java/mops/gruppen2/domain/exception/NoValueException.java

@@ -1,10 +0,0 @@
-package mops.gruppen2.domain.exception;
-
-import org.springframework.http.HttpStatus;
-
-public class NoValueException extends EventException {
-
-    public NoValueException(String info) {
-        super(HttpStatus.BAD_REQUEST, "Eine Information fehlt.", info);
-    }
-}