christoph/lecture-professional-software-development
1
Fork 0
Code Activity

Refactor ControllerService

Browse Source
This commit is contained in:
XXNitram
2020-03-18 18:02:11 +01:00
parent c631f243a1
commit 40d1c898e8
1 changed files with 2 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/main/java/mops/gruppen2/service/ControllerService.java
View File

@ -23,20 +23,11 @@ public class ControllerService {
this.inviteLinkRepositoryService = inviteLinkRepositoryService; this.inviteLinkRepositoryService = inviteLinkRepositoryService;
} }
/**
* Erzeugt eine neue Gruppe, fügt den User, der die Gruppe erstellt hat, hinzu und setzt seine Rolle als Admin fest.
* Zudem wird der Gruppentitel und die Gruppenbeschreibung erzeugt, welche vorher der Methode übergeben wurden.
* Aus diesen Event Objekten wird eine Liste erzeugt, welche daraufhin mithilfe des EventServices gesichert wird.
*
* @param account Keycloak-Account
* @param title Gruppentitel
* @param description Gruppenbeschreibung
*/
public void createGroup(Account account, String title, String description, Boolean visibility) throws EventException { public void createGroup(Account account, String title, String description, Boolean visibility) throws EventException {
Visibility visibility1; Visibility visibility1;
Long group_id = eventService.checkGroup(); Long group_id = eventService.checkGroup();
if(visibility) { if (visibility) {
visibility1 = Visibility.PUBLIC; visibility1 = Visibility.PUBLIC;
} else { } else {
visibility1 = Visibility.PRIVATE; visibility1 = Visibility.PRIVATE;
@ -88,7 +79,7 @@ public class ControllerService {
if(member.getUser_id().equals(user_id)) user = member; if(member.getUser_id().equals(user_id)) user = member;
} }
assert user != null; assert user != null;
if(group.getRoles().get(user.getUser_id()) == Role.ADMIN) { if (group.getRoles().get(user.getUser_id()) == Role.ADMIN) {
updateRoleEvent = new UpdateRoleEvent(group_id, user.getUser_id(), Role.MEMBER); updateRoleEvent = new UpdateRoleEvent(group_id, user.getUser_id(), Role.MEMBER);
} else { } else {
updateRoleEvent = new UpdateRoleEvent(group_id, user.getUser_id(), Role.ADMIN); updateRoleEvent = new UpdateRoleEvent(group_id, user.getUser_id(), Role.ADMIN);
@ -130,6 +121,5 @@ public class ControllerService {
updateDescription(account, group_id, description); updateDescription(account, group_id, description);
updateRole(account.getName(), group_id); updateRole(account.getName(), group_id);
addUserList(users, group_id); addUserList(users, group_id);
} }
} }