Large database migration

formula10/database/update_queries.py

@@ -6,6 +6,7 @@ from werkzeug import Response
 from formula10.controller.error_controller import error_redirect
 
 from formula10.database.common_queries import race_has_result, user_exists_and_disabled, user_exists_and_enabled
+from formula10.database.model.db_race import DbRace
 from formula10.database.model.db_race_guess import DbRaceGuess
 from formula10.database.model.db_race_result import DbRaceResult
 from formula10.database.model.db_season_guess import DbSeasonGuess
@@ -14,159 +15,167 @@ from formula10.database.validation import any_is_none, positions_are_contiguous,
 from formula10 import ENABLE_TIMING, db
 
 
-def find_or_create_race_guess(user_name: str, race_name: str) -> DbRaceGuess:
+def find_or_create_race_guess(user_id: int, race_id: int) -> DbRaceGuess:
     # There can be a single RaceGuess at most, since (user_name, race_name) is the composite primary key
-    race_guess: DbRaceGuess | None = db.session.query(DbRaceGuess).filter_by(user_name=user_name, race_name=race_name).first()
+    race_guess: DbRaceGuess | None = db.session.query(DbRaceGuess).filter_by(user_id=user_id, race_id=race_id).first()
     if race_guess is not None:
         return race_guess
 
     # Insert a new RaceGuess
-    race_guess = DbRaceGuess(user_name=user_name, race_name=race_name, pxx_driver_name="TEMP", dnf_driver_name="TEMP")
+    race_guess = DbRaceGuess(user_id=user_id, race_id=race_id)
+    race_guess.pxx_driver_id = 9999
+    race_guess.dnf_driver_id = 9999
     db.session.add(race_guess)
     db.session.commit()
 
     # Double check if database insertion worked and obtain any values set by the database
-    race_guess = db.session.query(DbRaceGuess).filter_by(user_name=user_name, race_name=race_name).first()
+    race_guess = db.session.query(DbRaceGuess).filter_by(user_id=user_id, race_id=race_id).first()
     if race_guess is None:
         raise Exception("Failed adding RaceGuess to the database")
 
     return race_guess
 
 
-def update_race_guess(race_name: str, user_name: str, pxx_select: str | None, dnf_select: str | None) -> Response:
-    if any_is_none(pxx_select, dnf_select):
-        return error_redirect(f"Picks for race \"{race_name}\" were not saved, because you did not fill all the fields.")
+def update_race_guess(race_id: int, user_id: int, pxx_select_id: int | None, dnf_select_id: int | None) -> Response:
+    if any_is_none(pxx_select_id, dnf_select_id):
+        return error_redirect(f"Picks for race \"{race_id}\" were not saved, because you did not fill all the fields.")
 
-    if ENABLE_TIMING and race_has_started(race_name=race_name):
-        return error_redirect(f"No picks for race \"{race_name}\" can be entered, as this race has already started.")
+    if ENABLE_TIMING and race_has_started(race_id=race_id):
+        return error_redirect(f"No picks for race \"{race_id}\" can be entered, as this race has already started.")
 
-    if race_has_result(race_name):
-        return error_redirect(f"No picks for race \"{race_name}\" can be entered, as this race has already finished.")
+    if race_has_result(race_id):
+        return error_redirect(f"No picks for race \"{race_id}\" can be entered, as this race has already finished.")
 
-    pxx_driver_name: str = cast(str, pxx_select)
-    dnf_driver_name: str = cast(str, dnf_select)
+    pxx_driver_id: int = cast(int, pxx_select_id)
+    dnf_driver_id: int = cast(int, dnf_select_id)
 
-    race_guess: DbRaceGuess = find_or_create_race_guess(user_name, race_name)
-    race_guess.pxx_driver_name = pxx_driver_name
-    race_guess.dnf_driver_name = dnf_driver_name
+    race_guess: DbRaceGuess = find_or_create_race_guess(user_id, race_id)
+    race_guess.pxx_driver_id = pxx_driver_id
+    race_guess.dnf_driver_id = dnf_driver_id
 
     db.session.commit()
 
     return redirect("/race/Everyone")
 
 
-def delete_race_guess(race_name: str, user_name: str) -> Response:
+def delete_race_guess(race_id: int, user_id: int) -> Response:
     # Don't change guesses that are already over
-    if ENABLE_TIMING and race_has_started(race_name=race_name):
-        return error_redirect(f"No picks for race \"{race_name}\" can be deleted, as this race has already started.")
+    if ENABLE_TIMING and race_has_started(race_id=race_id):
+        return error_redirect(f"No picks for race with id \"{race_id}\" can be deleted, as this race has already started.")
 
-    if race_has_result(race_name):
-        return error_redirect(f"No picks for race \"{race_name}\" can be deleted, as this race has already finished.")
+    if race_has_result(race_id):
+        return error_redirect(f"No picks for race \"{race_id}\" can be deleted, as this race has already finished.")
 
     # Does not throw if row doesn't exist
-    db.session.query(DbRaceGuess).filter_by(race_name=race_name, user_name=user_name).delete()
+    db.session.query(DbRaceGuess).filter_by(race_id=race_id, user_id=user_id).delete()
     db.session.commit()
 
     return redirect("/race/Everyone")
 
 
-def find_or_create_season_guess(user_name: str) -> DbSeasonGuess:
+def find_or_create_season_guess(user_id: int) -> DbSeasonGuess:
     # There can be a single SeasonGuess at most, since user_name is the primary key
-    season_guess: DbSeasonGuess | None = db.session.query(DbSeasonGuess).filter_by(user_name=user_name).first()
+    season_guess: DbSeasonGuess | None = db.session.query(DbSeasonGuess).filter_by(user_id=user_id).first()
     if season_guess is not None:
         return season_guess
 
     # Insert a new SeasonGuess
-    season_guess = DbSeasonGuess(user_name=user_name, team_winners_driver_names_json=json.dumps(["TEMP"]), podium_drivers_driver_names_json=json.dumps(["TEMP"]))
+    season_guess = DbSeasonGuess(user_id=user_id)
+    season_guess.team_winners_driver_ids_json=json.dumps(["9999"])
+    season_guess.podium_drivers_driver_ids_json=json.dumps(["9999"])
     db.session.add(season_guess)
     db.session.commit()
 
     # Double check if database insertion worked and obtain any values set by the database
-    season_guess = db.session.query(DbSeasonGuess).filter_by(user_name=user_name).first()
+    season_guess = db.session.query(DbSeasonGuess).filter_by(user_id=user_id).first()
     if season_guess is None:
         raise Exception("Failed adding SeasonGuess to the database")
 
     return season_guess
 
 
-def update_season_guess(user_name: str, guesses: List[str | None], team_winner_guesses: List[str | None], podium_driver_guesses: List[str]) -> Response:
+def update_season_guess(user_id: int, guesses: List[str | None], team_winner_guesses: List[str | None], podium_driver_guesses: List[str]) -> Response:
     # Pylance marks type errors here, but those are intended. Columns are marked nullable.
 
-    if ENABLE_TIMING and race_has_started(race_name="Bahrain"):
+    if ENABLE_TIMING and race_has_started(race_id=1):
         return error_redirect("No season picks can be entered, as the season has already begun!")
 
-    season_guess: DbSeasonGuess = find_or_create_season_guess(user_name)
+    season_guess: DbSeasonGuess = find_or_create_season_guess(user_id)
     season_guess.hot_take = guesses[0]  # type: ignore
-    season_guess.p2_team_name = guesses[1]  # type: ignore
-    season_guess.overtake_driver_name = guesses[2]  # type: ignore
-    season_guess.dnf_driver_name = guesses[3]  # type: ignore
-    season_guess.gained_driver_name = guesses[4]  # type: ignore
-    season_guess.lost_driver_name = guesses[5]  # type: ignore
-    season_guess.team_winners_driver_names_json = json.dumps(team_winner_guesses)
-    season_guess.podium_drivers_driver_names_json = json.dumps(podium_driver_guesses)
+    season_guess.p2_team_id = guesses[1]  # type: ignore
+    season_guess.overtake_driver_id = guesses[2]  # type: ignore
+    season_guess.dnf_driver_id = guesses[3]  # type: ignore
+    season_guess.gained_driver_id = guesses[4]  # type: ignore
+    season_guess.lost_driver_id = guesses[5]  # type: ignore
+    season_guess.team_winners_driver_ids_json = json.dumps(team_winner_guesses)
+    season_guess.podium_drivers_driver_ids_json = json.dumps(podium_driver_guesses)
 
     db.session.commit()
 
     return redirect(f"/season/Everyone")
 
 
-def find_or_create_race_result(race_name: str) -> DbRaceResult:
+def find_or_create_race_result(race_id: int) -> DbRaceResult:
     # There can be a single RaceResult at most, since race_name is the primary key
-    race_result: DbRaceResult | None = db.session.query(DbRaceResult).filter_by(race_name=race_name).first()
+    race_result: DbRaceResult | None = db.session.query(DbRaceResult).filter_by(race_id=race_id).first()
     if race_result is not None:
         return race_result
 
-    race_result = DbRaceResult(race_name=race_name,
-                               pxx_driver_names_json=json.dumps(["TEMP"]),
-                               first_dnf_driver_names_json=json.dumps(["TEMP"]),
-                               dnf_driver_names_json=json.dumps(["TEMP"]),
-                               excluded_driver_names_json=json.dumps(["TEMP"]))
+    race_result = DbRaceResult(race_id=race_id)
+    race_result.pxx_driver_ids_json = json.dumps(["9999"])
+    race_result.first_dnf_driver_ids_json = json.dumps(["9999"])
+    race_result.dnf_driver_ids_json = json.dumps(["9999"])
+    race_result.excluded_driver_ids_json = json.dumps(["9999"])
     db.session.add(race_result)
     db.session.commit()
 
     # Double check if database insertion worked and obtain any values set by the database
-    race_result = db.session.query(DbRaceResult).filter_by(race_name=race_name).first()
+    race_result = db.session.query(DbRaceResult).filter_by(race_id=race_id).first()
     if race_result is None:
         raise Exception("Failed adding RaceResult to the database")
 
     return race_result
 
 
-def update_race_result(race_name: str, pxx_driver_names_list: List[str], first_dnf_driver_names_list: List[str], dnf_driver_names_list: List[str], excluded_driver_names_list: List[str]) -> Response:
-    if ENABLE_TIMING and not race_has_started(race_name=race_name):
+def update_race_result(race_id: int, pxx_driver_ids_list: List[str], first_dnf_driver_ids_list: List[str], dnf_driver_ids_list: List[str], excluded_driver_ids_list: List[str]) -> Response:
+    if ENABLE_TIMING and not race_has_started(race_id=race_id):
         return error_redirect("No race result can be entered, as the race has not begun!")
 
     # Use strings as keys, as these dicts will be serialized to json
     pxx_driver_names: Dict[str, str] = {
-        str(position + 1): driver for position, driver in enumerate(pxx_driver_names_list)
+        str(position + 1): driver_id for position, driver_id in enumerate(pxx_driver_ids_list)
     }
 
     # Not counted drivers have to be at the end
     excluded_driver_names: Dict[str, str] = {
-        str(position + 1): driver for position, driver in enumerate(pxx_driver_names_list)
-        if driver in excluded_driver_names_list
+        str(position + 1): driver_id for position, driver_id in enumerate(pxx_driver_ids_list)
+        if driver_id in excluded_driver_ids_list
     }
     if len(excluded_driver_names) > 0 and (not "20" in excluded_driver_names or not positions_are_contiguous(list(excluded_driver_names.keys()))):
         return error_redirect("Race result was not saved, as excluded drivers must be contiguous and at the end of the field!")
 
     # First DNF drivers have to be contained in DNF drivers
-    for driver_name in first_dnf_driver_names_list:
-        if driver_name not in dnf_driver_names_list:
-            dnf_driver_names_list.append(driver_name)
+    for driver_id in first_dnf_driver_ids_list:
+        if driver_id not in dnf_driver_ids_list:
+            dnf_driver_ids_list.append(driver_id)
 
     # There can't be dnfs but no initial dnfs
-    if len(dnf_driver_names_list) > 0 and len(first_dnf_driver_names_list) == 0:
+    if len(dnf_driver_ids_list) > 0 and len(first_dnf_driver_ids_list) == 0:
         return error_redirect("Race result was not saved, as there cannot be DNFs without (an) initial DNF(s)!")
 
-    race_result: DbRaceResult = find_or_create_race_result(race_name)
-    race_result.pxx_driver_names_json = json.dumps(pxx_driver_names)
-    race_result.first_dnf_driver_names_json = json.dumps(first_dnf_driver_names_list)
-    race_result.dnf_driver_names_json = json.dumps(dnf_driver_names_list)
-    race_result.excluded_driver_names_json = json.dumps(excluded_driver_names_list)
+    race_result: DbRaceResult = find_or_create_race_result(race_id)
+    race_result.pxx_driver_ids_json = json.dumps(pxx_driver_names)
+    race_result.first_dnf_driver_ids_json = json.dumps(first_dnf_driver_ids_list)
+    race_result.dnf_driver_ids_json = json.dumps(dnf_driver_ids_list)
+    race_result.excluded_driver_ids_json = json.dumps(excluded_driver_ids_list)
 
     db.session.commit()
 
-    return redirect(f"/result/{quote(race_name)}")
+    race: DbRace | None = db.session.query(DbRace).filter_by(id=race_id).first()
+    if race is None:
+        raise Exception(f"Could not find DbRace with id {race_id}")
+
+    return redirect(f"/result/{quote(race.name)}")
 
 
 def update_user(user_name: str | None, add: bool = False, delete: bool = False) -> Response:
@@ -194,7 +203,9 @@ def update_user(user_name: str | None, add: bool = False, delete: bool = False)
             disabled_user.enabled = True
 
         else:
-            user: DbUser = DbUser(name=user_name, enabled=True)
+            user: DbUser = DbUser(id=None)
+            user.name = user_name
+            user.enabled = True
             db.session.add(user)
 
         db.session.commit()