christoph/fail
1
Fork 0
Code Actions Packages Releases Activity

util/DwarfReader, ElfImporter: use unsigned addresses

Browse Source 
This change alters DwarfReader and import-trace's ElfImporter so that they use
unsigned int for static address and line numbers instead of signed int.

Change-Id: I84ebbb500afd7cd4d93b137a35dcf736dc679fab
This commit is contained in:
Michael Lenz
2014-10-15 17:11:06 +02:00
parent 8fcbc7eeae
commit d94b005be2
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/util/DwarfReader.cc
View File

@ -234,7 +234,7 @@ bool DwarfReader::read_mapping(std::string fileName, std::list<addrToLine>& addr
} }
if (lineNo&&isCode) { if (lineNo&&isCode) {
struct addrToLine newLine = { (int) addr, (int) lineNo, normalize(lineSource) }; struct addrToLine newLine = { addr, lineNo, normalize(lineSource) };
addrToLineList.push_back(newLine); addrToLineList.push_back(newLine);
} }

4
src/core/util/DwarfReader.hpp
View File

@ -16,8 +16,8 @@ namespace fail {
*/ */
struct addrToLine { struct addrToLine {
int absoluteAddr; unsigned absoluteAddr;
int lineNumber; unsigned lineNumber;
std::string lineSource; std::string lineSource;
}; };

6
tools/import-trace/ElfImporter.cc
View File

@ -40,7 +40,7 @@ bool ElfImporter::create_database()
create_statement.str(""); create_statement.str("");
create_statement << "CREATE TABLE IF NOT EXISTS objdump (" create_statement << "CREATE TABLE IF NOT EXISTS objdump ("
" variant_id int(11) NOT NULL," " variant_id int(11) NOT NULL,"
" instr_address int(11) NOT NULL," " instr_address int(11) UNSIGNED NOT NULL,"
" opcode varchar(32) NOT NULL," " opcode varchar(32) NOT NULL,"
" disassemble VARCHAR(64)," " disassemble VARCHAR(64),"
" comment VARCHAR(128)," " comment VARCHAR(128),"
@ -77,8 +77,8 @@ bool ElfImporter::create_database()
create_statement.str(""); create_statement.str("");
create_statement << "CREATE TABLE IF NOT EXISTS dbg_mapping (" create_statement << "CREATE TABLE IF NOT EXISTS dbg_mapping ("
" variant_id int(11) NOT NULL," " variant_id int(11) NOT NULL,"
" instr_absolute int(11) NOT NULL," " instr_absolute int(11) UNSIGNED NOT NULL,"
" linenumber int(11) NOT NULL," " linenumber int(11) UNSIGNED NOT NULL,"
" file_id int(11) NOT NULL," " file_id int(11) NOT NULL,"
" PRIMARY KEY (variant_id, instr_absolute ,linenumber)" " PRIMARY KEY (variant_id, instr_absolute ,linenumber)"
") engine=MyISAM "; ") engine=MyISAM ";