From a19eb6db747b082360f6abe7e2906c63a9a12f9c Mon Sep 17 00:00:00 2001
From: Horst Schirmeier <horst.schirmeier@tu-dortmund.de>
Date: Sat, 7 Feb 2015 15:58:23 +0100
Subject: [PATCH] DwarfReader: fix premature fd close

When Richard decided we need not yet give up when dwarf_srclines()
fails, he left a -- now premature -- close(fd) behind.  Found by
Coverity Scan, CID 25806.

Change-Id: I0bc0cb6796225c9efaf5290e2799b6814f88e5b4
---
 src/core/util/DwarfReader.cc | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/core/util/DwarfReader.cc b/src/core/util/DwarfReader.cc
index 0a56e4ff..ed1b5186 100644
--- a/src/core/util/DwarfReader.cc
+++ b/src/core/util/DwarfReader.cc
@@ -232,8 +232,13 @@ bool DwarfReader::read_mapping(std::string fileName, std::list<DwarfLineMapping>
 		Dwarf_Line* lineBuffer;
 		Dwarf_Signed lineCount;
 		if (dwarf_srclines(die,&lineBuffer,&lineCount,0)!=DW_DLV_OK) {
+#if 0
 			close(fd);
-			continue; //return false;
+			return false;
+#else
+			// Richard decided this case is OK
+			continue;
+#endif
 		}
 
 		// Store them