christoph/fail
1
Fork 0
Code Releases Activity

visualfail: off-by-one in getHighlevelCode()

Browse Source 
This one omitted mappings to the first static instruction belonging to a
high-level source-code line.

Change-Id: I14427021e61f27a8b029fb56fad2ba813652422a
This commit is contained in:
Horst Schirmeier
2015-01-06 15:13:05 +01:00
parent 1faa885cb4
commit 9df01a4a48
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tools/analysis/VisualFAIL/core.php
View File

@ -260,7 +260,8 @@ function getHighlevelCode()
$maxFehler[$val] = 0; $maxFehler[$val] = 0;
} }
foreach ($value as $index => $ranges) { foreach ($value as $index => $ranges) {
$InstrMappingAbfrage = "SELECT instr_address, disassemble FROM objdump WHERE variant_id = '" . $_GET['variant_id']. "' AND instr_address > '" . $ranges[0] . "' AND instr_address < '" . $ranges[1] . "' ORDER BY instr_address;"; // was ">" instead of ">=" before
$InstrMappingAbfrage = "SELECT instr_address, disassemble FROM objdump WHERE variant_id = '" . $_GET['variant_id']. "' AND instr_address >= '" . $ranges[0] . "' AND instr_address < '" . $ranges[1] . "' ORDER BY instr_address;";
$mappingErgebnis = mysql_query($InstrMappingAbfrage); $mappingErgebnis = mysql_query($InstrMappingAbfrage);
//Leerzeile //Leerzeile
$mapping[$lineNumber] [] = '<br>'; $mapping[$lineNumber] [] = '<br>';