christoph/fail
1
Fork 0
Code Releases Activity

ProtoStream: member variable -> local var

Browse Source 
The contained state is not used over function boundaries anyways.
Found by Coverity Scan, CID 25689.

Change-Id: I34e42c227710be4859f6d62de9311c4201ed29b0
This commit is contained in:
Horst Schirmeier
2015-02-07 15:21:54 +01:00
parent e99e4aafa8
commit 6a0214b132
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/core/util/ProtoStream.cc
View File

@ -11,7 +11,7 @@ ProtoOStream::ProtoOStream(std::ostream *outfile) : m_outfile(outfile)
bool ProtoOStream::writeMessage(google::protobuf::Message *m) bool ProtoOStream::writeMessage(google::protobuf::Message *m)
{ {
m_size = htonl(m->ByteSize()); uint32_t m_size = htonl(m->ByteSize());
m_outfile->write(reinterpret_cast<char*>(&m_size), sizeof(m_size)); m_outfile->write(reinterpret_cast<char*>(&m_size), sizeof(m_size));
if (m_outfile->bad()) { if (m_outfile->bad()) {
@ -40,6 +40,7 @@ void ProtoIStream::reset()
bool ProtoIStream::getNext(google::protobuf::Message *m) bool ProtoIStream::getNext(google::protobuf::Message *m)
{ {
uint32_t m_size;
m_infile->read(reinterpret_cast<char*>(&m_size), sizeof(m_size)); m_infile->read(reinterpret_cast<char*>(&m_size), sizeof(m_size));
if (!m_infile->good()) if (!m_infile->good())
return false; return false;

5
src/core/util/ProtoStream.hpp
View File

@ -34,7 +34,7 @@ namespace fail {
*/ */
class ProtoOStream { class ProtoOStream {
private: private:
uint32_t m_size; // TODO: comments needed here // TODO: comments needed here
Logger m_log; Logger m_log;
std::ostream* m_outfile; std::ostream* m_outfile;
public: public:
@ -56,8 +56,7 @@ public:
*/ */
class ProtoIStream { class ProtoIStream {
private: private:
uint32_t m_size; // TODO: comments needed here // TODO: comments needed here
long m_sizeOfInfile;
Logger m_log; Logger m_log;
std::istream *m_infile; std::istream *m_infile;
public: public: