christoph/fail
1
Fork 0
Code Actions Packages Releases Activity

prune-trace: do not sort ECs for sampling

Browse Source 
Sorting is too costly for large data sets, and not worth the
sampling-process speedup.

Change-Id: I622ff3ed9b352fc5c7586f9733d830be727b6a11
This commit is contained in:
Christoph Borchert
2014-12-18 12:51:32 +01:00
committed by Horst Schirmeier
parent b2b53380f4
commit 57e4541190
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tools/prune-trace/FESamplingPruner.cc
View File

@ -102,8 +102,7 @@ bool FESamplingPruner::sampling_prune(const fail::Database::Variant& variant)
ss << "SELECT instr2, instr2_absolute, data_address, time2-time1+1 AS duration" ss << "SELECT instr2, instr2_absolute, data_address, time2-time1+1 AS duration"
<< " FROM trace" << " FROM trace"
<< " WHERE variant_id = " << variant.id << " WHERE variant_id = " << variant.id
<< " AND accesstype = 'R'" << " AND accesstype = 'R'";
<< " ORDER BY duration DESC"; // speeds up sampling, but query may be slow
res = db->query_stream(ss.str().c_str()); res = db->query_stream(ss.str().c_str());
ss.str(""); ss.str("");
if (!res) return false; if (!res) return false;
@ -129,8 +128,7 @@ bool FESamplingPruner::sampling_prune(const fail::Database::Variant& variant)
<< " ON t.variant_id = p.variant_id AND t.data_address = p.data_address AND t.instr2 = p.instr2" << " ON t.variant_id = p.variant_id AND t.data_address = p.data_address AND t.instr2 = p.instr2"
<< " WHERE p.fspmethod_id = " << db->get_fspmethod_id("basic") << " WHERE p.fspmethod_id = " << db->get_fspmethod_id("basic")
<< " AND p.variant_id = " << variant.id << " AND p.variant_id = " << variant.id
<< " AND p.known_outcome = 0" << " AND p.known_outcome = 0";
<< " ORDER BY duration DESC"; // speeds up sampling, but query may be slow
res = db->query_stream(ss.str().c_str()); res = db->query_stream(ss.str().c_str());
ss.str(""); ss.str("");
if (!res) return false; if (!res) return false;