christoph/fail
1
Fork 0
Code Actions Packages Releases Activity

several FIXMEs on virtual BaseListener functions

Browse Source 
git-svn-id: https://www4.informatik.uni-erlangen.de/i4svn/danceos/trunk/devel/fail@1638 8c4709b5-6ec9-48aa-a5cd-a96041d1645a
This commit is contained in:
hsc
2012-09-13 20:08:39 +00:00
parent 15e965febf
commit 4e321409b7
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/core/sal/Listener.hpp
View File

@ -31,7 +31,7 @@ protected:
public: public:
BaseListener() : m_OccCounter(1), m_OccCounterInit(1), m_Parent(NULL) BaseListener() : m_OccCounter(1), m_OccCounterInit(1), m_Parent(NULL)
{ } { }
virtual ~BaseListener() { } virtual ~BaseListener() { } // FIXME remove from queues
/** /**
* This method is called when an experiment flow adds a new listener by * This method is called when an experiment flow adds a new listener by
* calling \c simulator.addListener() or \c simulator.addListenerAndResume(). * calling \c simulator.addListener() or \c simulator.addListenerAndResume().
@ -559,7 +559,7 @@ public:
* Creates a new timer listener. This can be used to implement a timeout- * Creates a new timer listener. This can be used to implement a timeout-
* mechanism in the experiment-flow. The timer starts automatically when * mechanism in the experiment-flow. The timer starts automatically when
* added to the simulator backend. * added to the simulator backend.
* @param timeout the time intervall in milliseconds (ms) * @param timeout the time interval in milliseconds (ms)
* @see SimulatorController::addListener * @see SimulatorController::addListener
*/ */
GenericTimerListener(unsigned timeout) : m_Timeout(timeout) { } GenericTimerListener(unsigned timeout) : m_Timeout(timeout) { }

4
src/core/sal/bochs/BochsListener.hpp
View File

@ -45,7 +45,7 @@ public:
*/ */
TimerListener(unsigned timeout) TimerListener(unsigned timeout)
: GenericTimerListener(timeout) { } : GenericTimerListener(timeout) { }
~TimerListener() { onDeletion(); } ~TimerListener() { onDeletion(); } // FIXME ~BaseListener should automatically dequeue a Listener, and then indirectly calls onDeletion. In the current implementation, no dequeueing happens at all.
/** /**
* This method is called when an experiment flow adds a new event by * This method is called when an experiment flow adds a new event by
@ -70,7 +70,7 @@ public:
* will be called *before* the event is actually triggered, i.e. before the * will be called *before* the event is actually triggered, i.e. before the
* corresponding coroutine is toggled. * corresponding coroutine is toggled.
*/ */
void onTrigger() { onDeletion(); } void onTrigger() { onDeletion(); } // FIXME It should NOT be a Listener's job to call its own onDeletion. ListenerManager should call onDeletion when it deletes a Listener from a queue.
// TODO/FIXME: bei neuer impl. anpassen // TODO/FIXME: bei neuer impl. anpassen
}; };