From 48423054b01e04e8240e1a5c882ff811433c6754 Mon Sep 17 00:00:00 2001 From: Horst Schirmeier Date: Sat, 7 Feb 2015 15:58:23 +0100 Subject: [PATCH] prune-trace: check 2nd cmd.parse() return value As the first cmd.parse() call was already checked before, parsing a second time should never fail. Nevertheless, we can look at the return value without much effort. Found by Coverity Scan, CID 25494. Change-Id: Id012cf7183fe7b2022d33e6cbcb19ba49b544c99 --- tools/prune-trace/main.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/prune-trace/main.cc b/tools/prune-trace/main.cc index 0a391889..4711a764 100644 --- a/tools/prune-trace/main.cc +++ b/tools/prune-trace/main.cc @@ -102,7 +102,10 @@ int main(int argc, char *argv[]) { } // Since the pruner might have added command line options, we need to // reparse all arguments. - cmd.parse(); + if (!cmd.parse()) { + std::cerr << "Error parsing arguments." << std::endl; + exit(-1); + } if (cmd[HELP] || cmd[UNKNOWN] || cmd.parser()->nonOptionsCount() > 0) { for (option::Option* opt = cmd[UNKNOWN]; opt; opt = opt->next()) {