Documentation: Cleanup

Doxygen docu is now build in ${PROJECT_BINARY_DIR}/doc.
(and other small changes.)

Change-Id: I3fef910307e104f120c4f770526c800cfd01a41f

src/core/util/CMakeLists.txt

@@ -43,5 +43,16 @@ if(${LIB_IBERTY} STREQUAL LIB_IBERTY-NOTFOUND)
   message(FATAL_ERROR "libiberty not found. Try installing binutils-dev: [ sudo aptitude install binutils-dev ]")
 endif()
 
+# objdump required by Diassembler.cc
+
+set(THE_OBJDUMP "${ARCH_TOOL_PREFIX}objdump")
+find_program(FAIL_OBJDUMP "${THE_OBJDUMP}" DOC "binutils object dump tool")
+if(${FAIL_OBJDUMP} STREQUAL FAIL_OBJDUMP-NOTFOUND)
+  message(FATAL_ERROR "Cannot find objdump exeuctable (tried: ${THE_OBJDUMP}")
+else()
+  message(STATUS "[Fail*] objdump binary -> ${FAIL_OBJDUMP}")
+endif()
+mark_as_advanced(FAIL_OBJDUMP)
+
 add_library(fail-util ${SRCS})
 target_link_libraries(fail-util ${PROTOBUF_LIBRARY} ${Boost_LIBRARIES} ${LIB_IBERTY} )

src/core/util/Demangler.hpp

@@ -11,7 +11,7 @@ namespace fail {
       /**
        * Get the demangled symbol name of a mangled string.
        * @param name The mangled symbol
-       * @return The according demangled name if found, else Demangler:::DEMANGLE_FAILED
+       * @return The according demangled name if found, else Demangler::DEMANGLE_FAILED
        */
       static std::string demangle(const std::string & name);
 

src/core/util/Disassembler.cc

@@ -9,6 +9,7 @@
 #include <boost/regex.hpp>
 #include <boost/algorithm/string.hpp>
 #endif
+#include <stdlib.h>
 
 namespace fail {
 
@@ -21,7 +22,7 @@ namespace fail {
     char * elfpath = getenv("FAIL_ELF_PATH");
     if(elfpath == NULL){
       m_log << "FAIL_ELF_PATH not set :(" << std::endl;
-      return 0;
+      exit(EXIT_FAILURE);
     }else{
       return init(elfpath);
     }
@@ -44,7 +45,7 @@ namespace fail {
       if(ex != 0){
         m_code.clear();
         m_log << "Could not disassemble!" << std::endl;
-        return 0;
+        exit(EXIT_FAILURE);
       }
     }
     m_log << "disassembled " << m_code.size() << " lines." << std::endl;

src/core/util/Disassembler.hpp

@@ -9,8 +9,8 @@
 
 namespace fail {
 
-  //! Inform about failed disassembly
   struct DISASSEMBLER {
+    //! Inform about failed disassembly
     static const std::string FAILED;
   };
 
@@ -40,7 +40,7 @@ namespace fail {
       /**
        * Get disassembler instruction
        * @param address The instruction address
-       * @return The according disassembled instruction if found, else DISASSEMBLER:FAILED
+       * @return The according disassembled instruction if found, else DISASSEMBLER::FAILED
        */
       const Instruction & disassemble(address_t address) const;