From 2c176715ed5c9f8fdd3b902d0d0391ae75e7e006 Mon Sep 17 00:00:00 2001 From: Horst Schirmeier Date: Fri, 29 Jan 2016 17:55:59 +0100 Subject: [PATCH] import-trace: code comments + --help clarifications Change-Id: I796969f2dc8c7e440c9f9bd5434cbe09834057db --- tools/import-trace/ElfImporter.hpp | 15 +++++++-------- tools/import-trace/main.cc | 2 +- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/tools/import-trace/ElfImporter.hpp b/tools/import-trace/ElfImporter.hpp index 068b80ad..9c668622 100644 --- a/tools/import-trace/ElfImporter.hpp +++ b/tools/import-trace/ElfImporter.hpp @@ -17,15 +17,14 @@ already in place to import things related to an ELF binary into the database. - The ElfImporter calls objdump and dissassembles an ELF binary - and imports the results into the database + The ElfImporter calls objdump to dissassemble an ELF binary, and + imports the results into the database. - In addition, debugging information can be imported: - - If the --sources option is set, the source files will be imported - into the database. Only the files that were actually used in the - ELF binary will be imported. Additionally, the line number table of the - ELF binary will be imported into the database. + In addition, debugging information can be imported: If the --sources + option is set, the source files will be imported into the database. + Only the files that were actually used in the ELF binary will be imported. + Additionally, the line number table of the ELF binary will be imported + into the database. */ class ElfImporter : public Importer { llvm::OwningPtr binary; diff --git a/tools/import-trace/main.cc b/tools/import-trace/main.cc index dbc8bc13..9611c3a9 100644 --- a/tools/import-trace/main.cc +++ b/tools/import-trace/main.cc @@ -111,7 +111,7 @@ int main(int argc, char *argv[]) { "-e/--elf-file \tELF File (default: UNSET)"); CommandLine::option_handle MEMORYMAP = cmd.addOption("m", "memorymap", Arg::Required, - "-m/--memorymap \tMemory map to intersect with trace (may be used more than once; default: UNSET)"); + "-m/--memorymap \tMemory map to intersect with trace (if used more than once, the union of all maps will be used; default: UNSET)"); CommandLine::option_handle NO_DELETE = cmd.addOption("", "no-delete", Arg::None, "--no-delete \tAssume there are no DB entries for this variant/benchmark, don't issue a DELETE");