christoph/fail
1
Fork 0
Code Releases Activity

panda: read memory in chunks of 4 byte

Browse Source 
As openocd is able to read maximally 4-Byte sized chunks,
this will be done for performance improvement.

Change-Id: I79f85e580240f913b5a3d7b49bc0698390644ca8
This commit is contained in:
Lars Rademacher
2013-11-27 11:00:12 +01:00
parent 5142ff650e
commit 16ce7a4fee
1 changed files with 18 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/core/sal/panda/PandaMemory.hpp
View File

@ -49,15 +49,12 @@ public:
byte_t getByte(guest_address_t addr) byte_t getByte(guest_address_t addr)
{ {
// ToDo: Address translation // ToDo: Address translation
/* host_address_t haddr = guestToHost(addr);
assert(haddr != (host_address_t)ADDR_INV && "FATAL ERROR: Invalid guest address provided!");
return static_cast<byte_t>(*reinterpret_cast<Bit8u*>(haddr));*/
uint8_t buf [1]; uint8_t buf;
oocdw_read_from_memory(addr, 1, 1, buf); oocdw_read_from_memory(addr, 1, 1, &buf);
return buf[0]; return buf;
} }
/** /**
@ -71,13 +68,20 @@ public:
void getBytes(guest_address_t addr, size_t cnt, void *dest) void getBytes(guest_address_t addr, size_t cnt, void *dest)
{ {
// ToDo: Address translation // ToDo: Address translation
/* host_address_t haddr = guestToHost(addr);
assert(haddr != (host_address_t)ADDR_INV && "FATAL ERROR: Invalid guest address provided!");
return static_cast<byte_t>(*reinterpret_cast<Bit8u*>(haddr));*/
uint8_t *d = static_cast<uint8_t *>(dest); uint8_t *d = static_cast<uint8_t *>(dest);
oocdw_read_from_memory(addr, 1, cnt, d); // Write in 4-Byte chunks
// ToDo: Correct byte ordering?
if (cnt >= 4) {
oocdw_read_from_memory(addr, 4, cnt / 4, d);
}
if ((cnt % 4) != 0) {
oocdw_read_from_memory(addr + (cnt/4) * 4, 1, cnt % 4, d);
}
} }
/** /**
@ -88,6 +92,8 @@ public:
*/ */
void setByte(guest_address_t addr, byte_t data) void setByte(guest_address_t addr, byte_t data)
{ {
// ToDo: Address translation
oocdw_write_to_memory(addr, 1, 1, &data, true); oocdw_write_to_memory(addr, 1, 1, &data, true);
} }
@ -101,6 +107,8 @@ public:
*/ */
void setBytes(guest_address_t addr, size_t cnt, void const *src) void setBytes(guest_address_t addr, size_t cnt, void const *src)
{ {
// ToDo: Address translation
uint8_t const *s = static_cast<uint8_t const *>(src); uint8_t const *s = static_cast<uint8_t const *>(src);
// Write in 4-Byte chunks // Write in 4-Byte chunks