christoph/fail
1
Fork 0
Code Releases Activity

use uint32 for addresses in protobuf msgs

Browse Source 
This prevents integer overflows when using addresses > 2GiB, which are
common for x86 operating systems with paging (Linux, Fiasco.OC) or
some test cases on the PandaBoard.

Note that this results in slightly different result table definitions
when automatically translating an experiment's protobuf message in the
DatabaseCampaign.

This change affects all existing protobuf messages to prevent
copy/paste propagation of this issue.

Change-Id: I09ec4b9d45eddd67a7a24c8b101e8b2b258df5e2
This commit is contained in:
Horst Schirmeier
2013-11-30 19:54:12 +01:00
committed by Horst Schirmeier
parent 84edd02b6f
commit 122eb8c9dc
10 changed files with 44 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/experiments/nanojpeg/nanojpeg.proto
View File

@ -3,17 +3,17 @@ message NanoJPEGProtoMsg {
// (client executes one experiment for every specified bit in the target register)
// equivalence class start
required int32 instr_ecstart = 1;
required uint32 instr_ecstart = 1;
// FI at #instructions from experiment start
required int32 instr_offset = 2;
required uint32 instr_offset = 2;
// the exact IP value at this point in time (from golden run)
optional uint32 instr_address = 3; // for sanity checks
// ID of the register to inject faults into
required int32 register_id = 4;
required uint32 register_id = 4;
// bits to inject a bit flip into
required int64 bitmask = 5;
// timeout in ms
required int32 timeout = 6;
required uint32 timeout = 6;
// ----------------------------------------------------
@ -25,7 +25,7 @@ message NanoJPEGProtoMsg {
repeated group Result = 9 {
// single experiment bit number
required int32 bitnr = 1;
required uint32 bitnr = 1;
// result type:
// FINISHED = planned number of instructions were executed