christoph/fail
1
Fork 0
Code Actions Packages Releases Activity

use uint32 for addresses in protobuf msgs

Browse Source 
This prevents integer overflows when using addresses > 2GiB, which are
common for x86 operating systems with paging (Linux, Fiasco.OC) or
some test cases on the PandaBoard.

Note that this results in slightly different result table definitions
when automatically translating an experiment's protobuf message in the
DatabaseCampaign.

This change affects all existing protobuf messages to prevent
copy/paste propagation of this issue.

Change-Id: I09ec4b9d45eddd67a7a24c8b101e8b2b258df5e2
This commit is contained in:
Horst Schirmeier
2013-11-30 19:54:12 +01:00
committed by Horst Schirmeier
parent 84edd02b6f
commit 122eb8c9dc
10 changed files with 44 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/experiments/l4-sys/l4sys.proto
View File

@ -38,23 +38,23 @@ message L4SysProtoMsg {
repeated group Result = 3 {
// parameters
required int32 instr_offset = 1;
required int32 bit_offset = 2 [(sql_primary_key) = true];
required uint32 instr_offset = 1;
required uint32 bit_offset = 2 [(sql_primary_key) = true];
optional RegisterType register_offset = 3;
// instruction pointer where injection was done
optional int32 injection_ip = 4;
optional uint32 injection_ip = 4;
// result type, see above
optional ResultType resulttype = 5;
// result data, depending on resulttype (see source code)
optional int32 resultdata = 6;
optional uint32 resultdata = 6;
// generated output
optional string output = 7;
// optional textual description of what happened
optional string details = 8;
optional int32 injection_address = 9;
optional int32 deviate_steps = 10;
optional int32 deviate_eip = 11;
optional uint32 injection_address = 9;
optional uint32 deviate_steps = 10;
optional uint32 deviate_eip = 11;
}
}