christoph/fail
1
Fork 0
Code Releases Activity

use uint32 for addresses in protobuf msgs

Browse Source 
This prevents integer overflows when using addresses > 2GiB, which are
common for x86 operating systems with paging (Linux, Fiasco.OC) or
some test cases on the PandaBoard.

Note that this results in slightly different result table definitions
when automatically translating an experiment's protobuf message in the
DatabaseCampaign.

This change affects all existing protobuf messages to prevent
copy/paste propagation of this issue.

Change-Id: I09ec4b9d45eddd67a7a24c8b101e8b2b258df5e2
This commit is contained in:
Horst Schirmeier
2013-11-30 19:54:12 +01:00
committed by Horst Schirmeier
parent 84edd02b6f
commit 122eb8c9dc
10 changed files with 44 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/experiments/ecos_kernel_test/ecos_kernel_test.proto
View File

@ -8,13 +8,13 @@ message EcosKernelTestProtoMsg {
required string benchmark = 2;
// pilot ID (database)
required int32 pilot_id = 3;
required uint32 pilot_id = 3;
// FI at #instructions from experiment start
required int32 instr2_offset = 4;
required uint32 instr2_offset = 4;
// the exact IP value at this point in time (from golden run)
optional int32 instr2_address = 5; // for sanity checks
optional uint32 instr2_address = 5; // for sanity checks
// address of the byte to inject bit-flips
required int32 mem_addr = 6;
required uint32 mem_addr = 6;
// ----------------------------------------------------
@ -22,7 +22,7 @@ message EcosKernelTestProtoMsg {
// IP where we did the injection: for debugging purposes, must be identical
// to instr_address
optional int32 injection_ip = 7;
optional uint32 injection_ip = 7;
enum FaultModel {
SINGLEBITFLIP = 1;
@ -32,7 +32,7 @@ message EcosKernelTestProtoMsg {
repeated group Result = 8 {
// single experiment bit offset
required int32 bit_offset = 1;
required uint32 bit_offset = 1;
// result type:
// FINISHED = planned number of instructions were executed