From 0ed1a4e3061e73b3f7bad6e43e775c7bfdf88553 Mon Sep 17 00:00:00 2001
From: Horst Schirmeier <horst.schirmeier@tu-dortmund.de>
Date: Thu, 20 Nov 2014 17:12:07 +0100
Subject: [PATCH] visualfail: don't close MySQL connection too early

Luckily this didn't work as advertised, as the global connection
variable wasn't imported into the functions' scopes.

Change-Id: I080a32c6418deb3da3578987ec8a181b047608ad
---
 tools/analysis/VisualFAIL/core.php | 17 ++---------------
 1 file changed, 2 insertions(+), 15 deletions(-)

diff --git a/tools/analysis/VisualFAIL/core.php b/tools/analysis/VisualFAIL/core.php
index 95ffd2fa..d8a11179 100644
--- a/tools/analysis/VisualFAIL/core.php
+++ b/tools/analysis/VisualFAIL/core.php
@@ -21,6 +21,8 @@ switch ($_GET['kommando'])
 	case "dechex"			: echo json_encode(dechex($_GET['dec']));break;
 }
 
+mysql_close($verbindung);
+
 function dbTest()
 {
 
@@ -108,8 +110,6 @@ function getBinarys()
 
 	$ergebnis = mysql_query($abfrage);
 
-	mysql_close($verbindung);
-
 	while($row = mysql_fetch_object($ergebnis))
 	{
 		array_push($binarys, $row->benchmark);
@@ -128,8 +128,6 @@ function getVariants()
 
 	$ergebnis = mysql_query($abfrage);
 
-	mysql_close($verbindung);
-
 	while($row = mysql_fetch_object($ergebnis))
 	{
 		$variants[$row->id] = $row->variant;
@@ -146,8 +144,6 @@ function getSourceFiles()
 
 	$ergebnis = mysql_query($abfrage);
 
-	mysql_close($verbindung);
-
 	while($row = mysql_fetch_object($ergebnis))
 	{
 		$sourceFiles[$row->file_id] = $row->path;
@@ -164,7 +160,6 @@ function asmCode()
 
 	$ergebnis = mysql_query($abfrage);
 
-	mysql_close($verbindung);
 	$content = $content;
 	while($row = mysql_fetch_object($ergebnis))
 	{
@@ -306,8 +301,6 @@ function getHighlevelCode()
 		}
 	}
 
-	mysql_close($verbindung);
-
 	echo json_encode($content);
 }
 
@@ -317,8 +310,6 @@ function getResulttypes(&$resulttypes)
 
 	$ergebnis = mysql_query($abfrage);
 
-	mysql_close($verbindung);
-
 	while ($row = mysql_fetch_object($ergebnis)) {
 		//echo $row->resulttype;
 		array_push($resulttypes, $row->resulttype);
@@ -333,8 +324,6 @@ function getResulttypesOUT()
 
 	$ergebnis = mysql_query($abfrage);
 
-	mysql_close($verbindung);
-
 	while ($row = mysql_fetch_object($ergebnis)) {
 		//echo $row->resulttype;
 		array_push($resulttypes, $row->resulttype);
@@ -406,8 +395,6 @@ function askDBFehler($variant_id, $resulttypes, $version)
 
 	$ergebnis = mysql_query($abfrage);
 
-	mysql_close($verbindung);
-
 	return $ergebnis;
 }