christoph/fail
1
Fork 0
Code Releases Activity

Revert "generic-tracing: fix lossage of first event"

Browse Source 
This reverts commit 036e340bd9.

Problems with this one were:
 -  Broken event timings.  m_prevtime wasn't reset to m_curtime in
    TracingPlugin::handleSingleIP(), resulting in a large deltatime
    being recorded for the second event, too.  This effectively
    doubled the experiment's start time.
 -  Code repetition (copy/pasted for special handling of first event),
    making planned changes (advanced tracing for IP events) more
    difficult.
 -  Unnecessary additional tracing-plugin interface method.

Change-Id: I4b74d1a3f4563aabe6626399f9b30a2171b4c285
This commit is contained in:
Horst Schirmeier
2013-10-15 13:00:32 +02:00
parent 036e340bd9
commit 090125a283
3 changed files with 5 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/experiments/generic-tracing/experiment.cc
View File

@ -209,10 +209,6 @@ bool GenericTracing::run()
// this must be done *after* configuring the plugin:
simulator.addFlow(&tp);
// In order to not loose the IP event at the beginning of the
// trace, we have to handle the IP event manually
tp.handleSingleIP(l_start_symbol);
////////////////////////////////////////////////////////////////
// STEP 2: continue to the save point, and save state
if (start_symbol != save_symbol) {